[asan] Fix-forward undefined type in test from #153142 #153636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reported in llvm#153142 (comment) Fix by including stdint.h and using uintptr_t
llvmbot
added
compiler-rt
compiler-rt:asan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Thurston Dang (thurstond) ChangesFix Mac build breakage (reported by aeubanks in #153142 (comment)) by including stdint.h and using uintptr_t Full diff: https://github.com/llvm/llvm-project/pull/153636.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Posix/fakestack_alignment.cpp b/compiler-rt/test/asan/TestCases/Posix/fakestack_alignment.cpp
index ee52c405ae1a3..b25f3210e84f4 100644
--- a/compiler-rt/test/asan/TestCases/Posix/fakestack_alignment.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/fakestack_alignment.cpp
@@ -22,6 +22,7 @@
#include <assert.h>
#include <pthread.h>
#include <stdio.h>
+#include <stdint.h>
#include <stdlib.h>
#include <string.h>
@@ -35,7 +36,7 @@ bool misaligned = false;
// happen by chance, so try this on many threads.
void *Thread(void *unused) {
big_object x;
- uint alignment = (unsigned long)&x % alignof(big_object);
+ uintptr_t alignment = (uintptr_t)&x % alignof(big_object);
if (alignment != 0)
misaligned = true;
|
aeubanks
approved these changes
Aug 14, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
fmayer
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Mac build breakage (reported by aeubanks in #153142 (comment)) by including stdint.h and using uintptr_t